On 23/3/2019 11:34 AM, YueHaibing wrote: > On 2019/3/23 18:25, Daniel Mack wrote: >> On 23/3/2019 11:15 AM, Pavel Machek wrote: >>> If I look at code below, there's no difference between DEFSTATE_KEEP >>> and DEFSTATE_ON, right? I can't see how it works. >> >> Ah, you're right. Yes, the "keep" branch needs to go away entirely. >> >> As the chip can't be queried for it's current state, the "keep" option >> doesn't make sense. The only option in DT should be turn the LED on or >> off at probe time. YueHaibing, can you add that to your patch? > > Ok. I will send v2 with this. Note that Jacek just applied a patch of mine that removes all pdata handling from this driver. In order to avoid merge conflicts, you might want to base your patch on top of that. https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git/commit/?h=for-next&id=bd7a59173aea Thanks, Daniel
