On 3/21/19 4:43 PM, Andy Shevchenko wrote:
On Wed, Mar 20, 2019 at 07:52:14PM +0100, Jacek Anaszewski wrote:
On 3/19/19 10:38 PM, Andy Shevchenko wrote:
MODULE_DEVICE_TABLE(i2c, pca963x_id);
+static const struct of_device_id of_pca963x_match[] = {
+ { .compatible = "nxp,pca9632", },
+ { .compatible = "nxp,pca9633", },
+ { .compatible = "nxp,pca9634", },
+ { .compatible = "nxp,pca9635", },
+ {}
+};
+MODULE_DEVICE_TABLE(of, of_pca963x_match);
+
Why these can't stay in the original location? The same is relevant
to the other patch.
I think that grouping of the ID tables is good, though I have no strong opinion
on that and may leave in the next iteration wherever they are now.
I agree that grouping is good, but I'd do it the other way round - move
i2c_device_id tables to the bottom of the driver, to be close to the
place of its use.
--
Best regards,
Jacek Anaszewski
