On 3/18/19 4:30 PM, Pavel Machek wrote:
If you want the patch accepted, you have to explain what it will fix
and why it can't cause regressions.
Regressions will come if this patch won't be accepted in case the company,
whose PCA PNP ID is, decides to allocate them for something completely
different.
Those won't be regressions.
My NAK stays. I explained what would be acceptable, and we are not
legally forced to do anything.
You could also talk to the original authors, and get explanation from
them.
This is similar to [0], and at least to be consistent we have to remove
the ACPI support for the drivers in question. Besides, really, having
hard proofs that these were not official ids renders any future
complaints about breaking someone entirely unjustified.
Applied both patches to the for-next branch of linux-leds.git.
Thanks.
[0]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/leds/leds-lp3952.c?id=96962178475ae8040f40dff3a44beb9f69181421
--
Best regards,
Jacek Anaszewski
