Hello, On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote: > +static void set_device(struct led_netdev_data *trigger_data, > + const char *buf, size_t size) "set_device" is a very generic name. Can you please prefix it with "ledtrig_netdev_"? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |