On Mon 2019-01-07 11:13:25, Daniel Mack wrote:
> On 7/1/2019 10:57 AM, Pavel Machek wrote:
> > On Mon 2019-01-07 08:34:36, Daniel Mack wrote:
> >> The only user of this driver in mainline has now moved to DTS, so the pdata
> >> code is no longer in use by anyone. Let's drop some dead code, and make the
> >> driver depend on CONFIG_OF.
> >
> > pavel@amd:/data/l/linux-next-32/arch/arm/mach-pxa$ grep -ri lt3593 .
> > ./raumfeld.c:/* LT3593 controlled backlight */
> > ./raumfeld.c:static struct gpio_led raumfeld_lt3593_led = {
> > ./raumfeld.c:static struct gpio_led_platform_data
> > raumfeld_lt3593_platform_data = {
> > ./raumfeld.c: .leds =
> > &raumfeld_lt3593_led,
> > ./raumfeld.c:static struct platform_device raumfeld_lt3593_device = {
> > ./raumfeld.c: .name = "leds-lt3593",
> > ./raumfeld.c: .platform_data =
> > &raumfeld_lt3593_platform_data,
> > ./raumfeld.c: * by an LT3593, earlier and later devices use PWM for
> > that. */
> > ./raumfeld.c:
> > platform_device_register(&raumfeld_lt3593_device);
> > pavel@amd:/data/l/linux-next-32/arch/arm/mach-pxa$
> >
> > That is today's -next. So... maybe your patch is a bit premature?
>
> That code is scheduled for removal in the next cycle. Besides, it has
> bitrot a lot over the past years, doesn't work anymore for multiple
> reasons and is of no help for anybody it its current state.
>
> And as the generic gpio_led_platform_data struct was used in this
> driver, there won't be any compile time issues either.
I'd suggest postponing this until we can see the code removed, at
least in -next.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
