On Tue, 2018-10-23 at 20:50 +0200, Jacek Anaszewski wrote: > > diff --git a/drivers/leds/leds-upboard.c b/drivers/leds/leds-upboard.c > > new file mode 100644 > > index 0000000..34a6973 > > --- /dev/null > > +++ b/drivers/leds/leds-upboard.c > > @@ -0,0 +1,104 @@ [] > > +#include <linux/kernel.h> > > +#include <linux/leds.h> > > +#include <linux/mfd/upboard.h> > > +#include <linux/module.h> > > +#include <linux/platform_device.h> > > +#include <linux/regmap.h> > > +#include <linux/acpi.h> > > The last include should go first to keep alphabetical order. There is no accepted single kernel style for #include file ordering. drivers/leds does not use a single style nor is this particular variant documented anywhere to my knowledge. Until such a time when either a local preferred style document or a treewide preferred style exists, please stop asking people to modify #include ordering for various styles like reverse christmas tree by length, alphabetic ordering, or other individual styles. My preferred style would always have kernel.h first as that may help with precompiled headers and overall kernel compilation time one day.
