On Mon 2018-08-06 15:33:12, Baolin Wang wrote: > Hi Pavel, > > On 6 August 2018 at 15:09, Pavel Machek <pavel@xxxxxx> wrote: > > Hi! > > > >> > In current implementation this file on read returns the number > >> > of remaining repeat intervals. I'd add that to this description. > >> > >> I saw Pavel's comments that he did not suggest do this. So I will keep > >> the original description? > > > > If that is accepted, the code should return originally written number. > > But I think it is more reasonable if user can know how many > repetitions were left. So for your hardware case, can we add > pattern_get() interface back to get the repetition number? Well, I'd say that we are mostly seeing "infinite" repetitions, or one repetition. Yes, interface could be added to the lowlever driver -- but I'm not sure hardware really supports getting that information; could be tricky on N900 for example. I'd keep it simple for now. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
