On Tue, Feb 27, 2018 at 10:15:31AM -0800, Tejun Heo wrote: > On Sat, Feb 24, 2018 at 11:45:56PM +0100, Linus Walleij wrote: > > This adds two new disk triggers for triggering on reads > > and writes respectively, named "disk-read" and "disk-write". > > > > The use case comes from working on the D-Link DNS-313 NAS > > box. This features an RGB LED for disk activity. with > > these two triggers I can couple the green LED to read > > activity and the red LED to write activity, which gives > > the appropriate user feedback about what is happening > > on the disk. When tested it gave exactly the feedback > > desired. > > > > The in-kernel interface is simply changed to pass a bool > > indicating if the activity is write activity and update > > each trigger (and the composite "disk-activity" trigger) > > depending on what is passed in. > > > > This requires an ACK from the libata/IDE maintainers. > > > > Cc: Tejun Heo <tj@xxxxxxxxxx> > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > > Cc: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> > > Cc: Pavel Machek <pavel@xxxxxx> > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > For libata part, > > Acked-by: Tejun Heo <tj@xxxxxxxxxx> Ooh, btw, we have READ and WRITE macros defined in linux/kernel.h. It might be a better idea to use them instead of bool. Thanks. -- tejun
