Re: [PATCH] leds: use QoS to control LED suspend behavior from userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> >> Sounds good, I'll start working on it. Though I can't help but think,
> >> if all devices share this pm_qos interface, couldn't the device tree
> >> interface be shared as well?
> >
> > Could you please elaborate on that?
> 
> It just seems odd to me that there does not seem to be a standard way
> to set QoS parameters like PM_QOS_FLAG_NO_POWER_OFF from the device
> tree. Each subsystem must define its own way of saying essentially the
> same thing afaik: leds-gpio chose 'retain-state-suspended' but it
> could be any variation on "don't power off this device in suspend".

Agreed, it would be nice to have something common.

Hmm, but please note that some devices support different sleep states
(standby, suspend, hibernation, poweroff).

> > My concern here is backward compatibility - current users expect that
> > once the property is set in DT, the behavior on suspend is guaranteed
> > to not change.

DT describes hardware, but it should be ok for (root) user to override
that.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux