> -----Original Message----- > From: Jacek Anaszewski [mailto:jacek.anaszewski@xxxxxxxxx] > Sent: Saturday, February 17, 2018 11:55 PM > To: Pavel Machek <pavel@xxxxxx> > Cc: Vadim Pasternak <vadimp@xxxxxxxxxxxx>; rpurdie@xxxxxxxxx; linux- > leds@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx > Subject: Re: [PATCH v9 2/2] leds: add driver for support Mellanox regmap LEDs > for BMC and x86 platform > > On 02/16/2018 11:25 PM, Pavel Machek wrote: > > Hi! > > > >>> +++ b/drivers/leds/leds-mlxreg.c > >>> @@ -0,0 +1,309 @@ > >>> +/* > >>> + * Copyright (c) 2018 Mellanox Technologies. All rights reserved. > >>> + * Copyright (c) 2018 Vadim Pasternak <vadimp@xxxxxxxxxxxx> > >>> + * > >>> + * Redistribution and use in source and binary forms, with or > >>> +without > >>> + * modification, are permitted provided that the following conditions are > met: > >>> + * > >>> + * 1. Redistributions of source code must retain the above copyright > >>> + * notice, this list of conditions and the following disclaimer. > >>> + * 2. Redistributions in binary form must reproduce the above copyright > >>> + * notice, this list of conditions and the following disclaimer in the > >>> + * documentation and/or other materials provided with the distribution. > >>> + * 3. Neither the names of the copyright holders nor the names of its > >>> + * contributors may be used to endorse or promote products derived > from > >>> + * this software without specific prior written permission. > >>> + * > >>> + * Alternatively, this software may be distributed under the terms > >>> +of the > >>> + * GNU General Public License ("GPL") version 2 as published by the > >>> +Free > >>> + * Software Foundation. > >>> + * > >>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > CONTRIBUTORS "AS IS" > >>> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > >>> +LIMITED TO, THE > >>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A > >>> +PARTICULAR PURPOSE > >>> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR > >>> +CONTRIBUTORS BE > >>> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, > >>> +OR > >>> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, > >>> +PROCUREMENT OF > >>> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR > >>> +BUSINESS > >>> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, > >>> +WHETHER IN > >>> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR > >>> +OTHERWISE) > >>> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF > >>> +ADVISED OF THE > >>> + * POSSIBILITY OF SUCH DAMAGE. > >>> + */ > > > > You may want to switch on to spdx next time you update the driver... > > > Pavel > > > > > > > Right, so I propose the following modification: > > diff --git a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c index > cc9f297..56d6f30 100644 > --- a/drivers/leds/leds-mlxreg.c > +++ b/drivers/leds/leds-mlxreg.c > @@ -1,35 +1,7 @@ > -/* > - * Copyright (c) 2018 Mellanox Technologies. All rights reserved. > - * Copyright (c) 2018 Vadim Pasternak <vadimp@xxxxxxxxxxxx> > - * > - * Redistribution and use in source and binary forms, with or without > - * modification, are permitted provided that the following conditions are met: > - * > - * 1. Redistributions of source code must retain the above copyright > - * notice, this list of conditions and the following disclaimer. > - * 2. Redistributions in binary form must reproduce the above copyright > - * notice, this list of conditions and the following disclaimer in the > - * documentation and/or other materials provided with the distribution. > - * 3. Neither the names of the copyright holders nor the names of its > - * contributors may be used to endorse or promote products derived from > - * this software without specific prior written permission. > - * > - * Alternatively, this software may be distributed under the terms of the > - * GNU General Public License ("GPL") version 2 as published by the Free > - * Software Foundation. > - * > - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > CONTRIBUTORS "AS IS" > - * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > LIMITED TO, THE > - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A > PARTICULAR PURPOSE > - * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR > CONTRIBUTORS BE > - * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > - * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, > PROCUREMENT OF > - * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR > BUSINESS > - * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, > WHETHER IN > - * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR > OTHERWISE) > - * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED > OF THE > - * POSSIBILITY OF SUCH DAMAGE. > - */ > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) // // Copyright > +(c) 2018 Mellanox Technologies. All rights reserved. > +// Copyright (c) 2018 Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > > > If everyone agrees I can fix the original commit in the linux-leds.git by myself. Acked. Thank you very much. Vadim. > > -- > Best regards, > Jacek Anaszewski
