Philippe, On 7 December 2017 at 13:01, Philippe Ombredanne <pombredanne@xxxxxxxx> wrote: > Ben, > > On Thu, Dec 7, 2017 at 12:46 PM, Ben Whitten <ben.whitten@xxxxxxxxx> wrote: >> From: Ben Whitten <ben.whitten@xxxxxxxxx> >> >> This commit introduces a NETDEV trigger for named device >> activity. Available triggers are link, rx, and tx. >> >> Signed-off-by: Ben Whitten <ben.whitten@xxxxxxxxx> > [] >> --- /dev/null >> +++ b/drivers/leds/trigger/ledtrig-netdev.c >> @@ -0,0 +1,503 @@ >> +/* >> + * LED Kernel Netdev Trigger >> + * >> + * Toggles the LED to reflect the link and traffic state of a named net device >> + * >> + * Copyright 2017 Ben Whitten <ben.whitten@xxxxxxxxx> >> + * >> + * Copyright 2007 Oliver Jowett <oliver@xxxxxxxxxxxxx> >> + * >> + * Derived from ledtrig-timer.c which is: >> + * Copyright 2005-2006 Openedhand Ltd. >> + * Author: Richard Purdie <rpurdie@xxxxxxxxxxxxxx> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + */ > > Have you considered using the new SPDX id instead ? See Thomas doc > patches and Greg and Linus comments on the topic > Here this would likely come out this way (yes, using a C++ comment at the top): > >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * LED Kernel Netdev Trigger >> + * >> + * Toggles the LED to reflect the link and traffic state of a named net device >> + * >> + * Copyright 2017 Ben Whitten <ben.whitten@xxxxxxxxx> >> + * >> + * Copyright 2007 Oliver Jowett <oliver@xxxxxxxxxxxxx> >> + * >> + * Derived from ledtrig-timer.c which is: >> + * Copyright 2005-2006 Openedhand Ltd. >> + * Author: Richard Purdie <rpurdie@xxxxxxxxxxxxxx> >> + * >> + */ > > > This is cleaner and simpler, don't you think? Much cleaner. Thank you for the suggestion, I was unaware of this. Kind regards, Ben Whitten
