Hi Jacek, On Tue, Sep 12, 2017 at 08:53:33PM +0200, Jacek Anaszewski wrote: > Hi Pavel, > > On 09/12/2017 12:36 PM, Pavel Machek wrote: > > Hi! > > > > There were some changes to as3645a flash controller. Before we have > > stable interface we have to keep forever I want to ask: > > Note that we have already two LED flash class drivers - leds-max77693 > and leds-aat1290. They have been present in mainline for over two years > now. > > > What directory are the flash controls in? > > > > /sys/class/leds/led-controller:flash ? > > > > Could we arrange for something less generic, like > > > > /sys/class/leds/main-camera:flash ? > > I'd rather avoid overcomplicating this. LED class device name pattern > is well defined to devicename:colour:function > (see Documentation/leds/leds-class.txt, "LED Device Naming" section). > > In this case "flash" in place of the "function" segment makes the > things clear enough I suppose. Oh. I have to admit I've completely missed this. :-o I'll address this in v2 of the as3645a fixes, plus submit related V4L2 flash class documentation fixes a little later. -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx
