On Thu 2017-08-17 13:28:47, Dan Carpenter wrote:
> Hello Nate Case,
>
> The patch f46e9203d9a1: "leds: Add support for Philips PCA955x I2C
> LED drivers" from Jul 16, 2008, leads to the following static checker
> warning:
>
> drivers/leds/leds-pca955x.c:476 pca955x_probe()
> warn: this array is probably non-NULL. 'pdata->leds + i->name'
>
> drivers/leds/leds-pca955x.c
> 465 switch (pca955x_led->type) {
> 466 case PCA955X_TYPE_NONE:
> 467 break;
> 468 case PCA955X_TYPE_GPIO:
> 469 ngpios++;
> 470 break;
> 471 case PCA955X_TYPE_LED:
> 472 /*
> 473 * Platform data can specify LED names and
> 474 * default triggers
> 475 */
> 476 if (pdata->leds[i].name)
> ^^^^^^^^^^^^^^^^^^^
> The comment implies that we should be testing pdata->leds[i].name[0] to
> see if any string has been set?
>
From: Colin King <colin.king@xxxxxxxxxxxxx>
To: Richard Purdie <rpurdie@xxxxxxxxx>, Jacek Anaszewski
<jacek.anaszewski@xxxxxxxxx>, Pavel
Machek <pavel@xxxxxx>, linux-leds@xxxxxxxxxxxxxxx
Cc: kernel-janitors@xxxxxxxxxxxxxxx,
linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH][leds-next] leds: pca955x: remove redundant
null check on array name
X-Mailer: git-send-email 2.11.0
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
The check to see if pdata-leds[i].name is redundant as name is
a 32 byte char array and hence can never be null. Remove the
redundant check.
Detected by CoverityScan, CID#1454218 ("Array compared against 0")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
drivers/leds/leds-pca955x.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
index f062d1e7640f..b12b7ea51867 100644
--- a/drivers/leds/leds-pca955x.c
+++ b/drivers/leds/leds-pca955x.c
@@ -473,10 +473,9 @@ static int pca955x_probe(struct i2c_client
*client,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
