> -----Original Message----- > From: Pavel Machek [mailto:pavel@xxxxxx] > Sent: Tuesday, August 08, 2017 10:45 AM > To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>; robh+dt@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; j.anaszewski@xxxxxxxxxxx; > rpurdie@xxxxxxxxx; linux-leds@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx; > jacek.anaszewski@xxxxxxxxx > Subject: Re: [patch v2 1/2] mfd: Add Mellanox regmap core driver > > Hi! > > > > Why don't you extend the support you already provide in > drivers/platform? > > > This seems like a logical place for an all encompassing device which > > > cannot be split out to individual subsystems. > > > > There is a problem to extend for that the existing driver > > drivers/platform/x86/mlxcpld-hotplug.c. > > It has been provided for x86 arch and I am planning to extend it with > > ACPI support. > > > > But in mlxreg-core I am using DTS, which is not supported for x86. > > Here I am using the next functions for probing and removing hotplug > > entities: > > static void mlxreg_core_dev_enable(struct device_node *np) { > > /* Enable and create device. */ > > of_update_property(np, &mlxreg_core_device_en); } > > > > static void mlxreg_core_dev_disable(struct device_node *np) { > > /* Disable and unregister platform device. */ > > of_update_property(np, &mlxreg_core_device_dis); > > of_node_clear_flag(np, OF_POPULATED); } > > > > And such code can't be placed under drivers/platform/x86/. > > So aim for drivers/platform/mlx ...? > So you suggest to move drivers/platform/x86/mlxcpld-hotplug.c to drivers/platform/mellanox/mlxcpld-hotplug.c and extend thr driver with DTS support (mlxreg_core_dev_enable/mlxreg_core_dev_disable)? > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) > http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
