Re: [patch v3 1/1] leds: add driver for support Mellanox regmap LEDs for BMC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!


> > =jacek.anaszewski@xxxxxxxxx

That email address looks funny.

> > > +/* Codes for LEDs. */
> > > +#define MLXREG_LED_OFFSET_HALF	0x01 /* Offset from solid:
> > 3Hz blink */
> > > +#define MLXREG_LED_OFFSET_FULL	0x02 /* Offset from solid:
> > 6Hz
> > 
> > Can it do half brightness?
> 
> 
> This is about blinking  frequency. Hardware support 6 hz blinking mode and 3hz blinking mode.
> If solid orange f.e. has bit mask 1100, setting 1101 or 1110 will blink orange with 3 or 6 KHz.

OFFSET_HALF -> OFFSET_BLINK_3HZ?

Otherwise looks good,

Acked-by: Pavel Machek <pavel@xxxxxx>
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux