Wed, Jul 26, 2017 at 01:18:46PM CEST, pavel@xxxxxx wrote:
>Hi!
>
[...]
>
>> +static void
>> +mlxreg_core_work_helper(struct mlxreg_core_priv_data *priv,
>> + struct mlxreg_core_item *item, u8 is_inverse,
>> + u16 off, u32 mask, u32 *cache)
>> +{
>> + struct mlxreg_core_data *data;
>> + u32 asserted, regval, bit;
>> + int ret;
>> +
>> + /*
>> + * Validate if item related to received signal type is valid.
>> + * It should never happen, excepted the situation when some
>> + * piece of hardware is broken. In such situation just produce
>> + * error message and return. Caller must continue to handle the
>> + * signals from other devices if any.
>> + */
>> + if (unlikely(!item)) {
>> + dev_err(priv->dev, "False signal is received: register at offset 0x%02x, mask 0x%02x.\n",
>> + off, mask);
>
>Slightly too long line.
That is totally ok to have it like that for printables though. Actually,
wraping the text in half would be wrong.
