Re: [PATCH] leds: leds-aat1290.c: enclosed arithmetic expression macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 2017-07-11 23:21:01, Lynn Lei wrote:
> Fixed the unenclosed complex values macro issue generated by
> scripts/checkpatch.pl:
> 	ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: Lynn Lei <lynnl.yet@xxxxxxxxx>

That's very very very stupid, right?

Please don't do random checkpatch cleanups, be careful and test your changes.

NAK.

									Pavel
> ---
>  drivers/leds/leds-aat1290.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
> index a21e19297745..061e2cfd8097 100644
> --- a/drivers/leds/leds-aat1290.c
> +++ b/drivers/leds/leds-aat1290.c
> @@ -35,7 +35,7 @@
>  #define AAT1290_MM_CURRENT_RATIO_ADDR	20
>  #define AAT1290_MM_TO_FL_1_92		1
>  
> -#define AAT1290_MM_TO_FL_RATIO		1000 / 1920
> +#define AAT1290_MM_TO_FL_RATIO		(1000 / 1920)
>  #define AAT1290_MAX_MM_CURRENT(fl_max)	(fl_max * AAT1290_MM_TO_FL_RATIO)
>  
>  #define AAT1290_LATCH_TIME_MIN_US	500

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux