On Tue 2017-06-13 10:39:20, Zhang Bo wrote: > This reverts commit 5ab92a7cb82c66bf30685583a38a18538e3807db. > > System cannot enter suspend mode because of heartbeat led trigger. > In autosleep_wq, try_to_suspend function will try to enter suspend > mode in specific period. it will get wakeup_count then call pm_notifier > chain callback function and freeze processes. > Heartbeat_pm_notifier is called and it call led_trigger_unregister to > change the trigger of led device to none. It will send uevent message > and the wakeup source count changed. As wakeup_count changed, suspend > will abort. > > Signed-off-by: Zhang Bo <bo.zhang@xxxxxxx> Yes, this makes sense. Turning led off should be done at driver level. As this fixes a regression, it would be kind of nice to get it to v4.12... Acked-by: Pavel Machek <pavel@xxxxxx> -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
