Hi! On Wed 2017-06-07 11:46:10, Linus Walleij wrote: > On Wed, Jun 7, 2017 at 9:12 AM, Pavel Machek <pavel@xxxxxx> wrote: > > > Core reason is that 5ab92a7cb is wrong. (Very wrong; it papers over > > the issue for one trigger, but we have more than one... Even if > > special handling for heartbeat is warranted, that handling would be > > "turn the led off" not "unregister the trigger", which is > > userland-visible action.) > > OK yeah I guess you're right. > > I just couldn't think about anything better and didn't get any > review at the time, so mistakes were made. > > > That one should be reverted, then maybe the > > driver should be fixed to turn the led off during suspend. > > Do you mean that the heartbeat trigger driver should be fixed to > turn off the LED during sleep? > > That is essentially what I was trying to achieve. I don't think we should be fixing it at trigger level. If userspace keeps blinking using "brightness" attribute, would we like the LED to be off during suspend? I think so. > The reason it is done as it is, is that the trigger sets up > a timer to do its job, and the timer may trigger between > the point you turn off the LED and the system really goes > to suspend, again maybe turning the LED on and > again leaving the system with a glowing LED at suspend. > The patch also solves the following phenomenon, sorry > for not writing in the commit: > > - Turn off LED > - Suspend I2C hardware > - Timer trigger > - Trying to blink the LED using I2C > - Crap in the console about the failed I2C transaction > - Actual suspen happens > - System comes online > - Trying to blink the LED using I2C > - Crap in the console about the failed I2C transaction > - Resume I2C hardware > > It's just very fragile this trigger, turning off the LED from > the PM notifier is obviously not enough, we also need to > disable the timer, and then take it back online after resume. No, leave the timer alone, and actually leave the trigger alone. Simply make the driver turn the LED off in .suspend() callback, and then ignore further requests until .resume(). That will get rid of power drain _and_ "failed I2C transaction" messages, right? (Actually, I tested with the heartbeat trigger, and it is not re-installed after resume. Another reason to revert the patch). Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
