Hi Luigi, On 05/04/2017 01:00 PM, Luigi Baldoni wrote: > This patch adds build support for PCEngines APU1/APU2 LEDs drivers. > > Signed-off-by: Christian Herzog <daduke@xxxxxxxxxx> > > --- > drivers/leds/Kconfig | 22 ++++ > drivers/leds/Makefile | 2 > 2 files changed, 24 insertions(+) > > Index: b/drivers/leds/Kconfig > =================================================================== > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -694,6 +694,28 @@ config LEDS_NIC78BX > To compile this driver as a module, choose M here: the module > will be called leds-nic78bx. > > +config LEDS_APU > + tristate "Front LED support for pcengines apu boards" > + depends on LEDS_CLASS > + depends on X86 && DMI > + help > + This driver makes the pcengines apu front LEDs accessible from > + userspace programs through the leds subsystem. > + > + To compile this driver as a module, choose M here: the > + module will be called leds-apu. > + > +config LEDS_APU2 > + tristate "Front LED support for pcengines apu2 boards" > + depends on LEDS_CLASS > + depends on X86 && DMI > + help > + This driver makes the pcengines apu2 front LEDs accessible from > + userspace programs through the leds subsystem. > + > + To compile this driver as a module, choose M here: the > + module will be called leds-apu2. > + > comment "LED Triggers" > source "drivers/leds/trigger/Kconfig" > > Index: b/drivers/leds/Makefile > =================================================================== > --- a/drivers/leds/Makefile > +++ b/drivers/leds/Makefile > @@ -73,6 +73,8 @@ obj-$(CONFIG_LEDS_PM8058) += leds-pm805 > obj-$(CONFIG_LEDS_MLXCPLD) += leds-mlxcpld.o > obj-$(CONFIG_LEDS_NIC78BX) += leds-nic78bx.o > obj-$(CONFIG_LEDS_MT6323) += leds-mt6323.o > +obj-$(CONFIG_LEDS_APU) += leds-apu.o > +obj-$(CONFIG_LEDS_APU2) += leds-apu2.o > > # LED SPI Drivers > obj-$(CONFIG_LEDS_DAC124S085) += leds-dac124s085.o > Please don't split Kconfig and Makefile modifications from the driver, since it would break bisect and doesn't have logical justification. -- Best regards, Jacek Anaszewski
