On 05/04/2017 02:28 PM, Pavel Machek wrote: > On Thu 2017-05-04 14:23:39, Linus Walleij wrote: >> On Thu, May 4, 2017 at 2:14 PM, Pavel Machek <pavel@xxxxxx> wrote: >> >>> On Thu 2017-05-04 14:03:08, Linus Walleij wrote: >>>> All users of the Versatile LED driver are deleted and replaced >>>> with the very generic leds-syscon. Delete the old driver. >>> >>> If someone has LEDS_VERSATILE selected, he'll be unhappy if we apply >>> first. >>> >>> Are you sure no _users_ have LEDS_VERSATILE selected? Should we give >>> them some kind of warning? (#warning, printk, ...?) >> >> Since the driver cannot probe from device tree or ACPI, the device must >> be created in a board file using the device name "versatile-leds" which is >> what the driver matches against. >> >> For them to use it they must have out-of-tree boardfiles, and we discourage >> both out-of-tree code and boardfiles. >> >> The last boardfiles using this were deleted in >> commit 7484c727b636a838818e71f6d03114633b25aba2 >> "ARM: realview: delete the RealView board files". >> >> All Versatile, Integrator and RealView boards (the only one using the >> versatile LEDs), have been migrated to use leds-syscon.c. > > Aha, people having out-of-tree boardfiles probably know enough to > handle this. > > Acked-by: Pavel Machek <pavel@xxxxxx> Applied to the for-4.13 branch of linux-leds.git, thanks. -- Best regards, Jacek Anaszewski
