* Sebastian Reichel <sre@xxxxxxxxxx> [170322 18:02]: > Hi, > > On Wed, Mar 22, 2017 at 08:57:16AM -0700, Tony Lindgren wrote: > > * Pavel Machek <pavel@xxxxxx> [170322 02:29]: > > > On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote: > > > > This fixes compilation for files, that try to include the > > > > cpcap header in alphabetically sorted #include lists. > > > > > > > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > > > > > > Acked-by: Pavel Machek <pavel@xxxxxx> > > > > Hmm I wonder why I never ran into this so far. No objections > > to the patch though if it fixes the issue with all the necessary > > headers included. > > Because you usually sort includes differently moving headers > from linux/subdir/XYZ after linux/XYZ. That way regmap.h and > device.h will already be included when the compiler includes > motorola-cpcap.h. Ah OK yeah I do that usually. Your patch seems OK to me: Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>