On 28 February 2017 at 22:20, Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote: > Thanks for the patch. How about following what has been already > done for spi, i.e. adding a wrapper of_led_classdev_register() > (please refer to of_register_spi_device() in drivers/spi/spi.c)? I like this idea, but I'll need to split led_classdev_register into two functions: allocation & actual registering function. That way I can alloc, then read DT proprties and finally register LED (just like it's done in of_register_spi_device). Does it sound OK?