2017-03-01 12:27 GMT+01:00 Pali Rohár <pali.rohar@xxxxxxxxx>: >> @@ -5164,7 +5162,7 @@ static void kbdlight_set_worker(struct work_struct *work) >> container_of(work, struct tpacpi_led_classdev, work); >> >> if (likely(tpacpi_lifecycle == TPACPI_LIFE_RUNNING)) >> - kbdlight_set_level_and_update(data->new_state); >> + kbdlight_set_level(data->new_state); >> } >> >> static void kbdlight_sysfs_set(struct led_classdev *led_cdev, > > Hi! This change was added in commit afcedebc6a0 (thinkpad_acpi: save > kbdlight state on suspend and restore it on resume). It is really OK to > revert that change? > > CCing Marco who is author of that commit. I think that as per commit c685e20df this is actually not needed anymore, as it will be userspace to handle that. So it's fine to me. Thanks for asking, though