On Thu, Feb 9, 2017, at 13:44, Hans de Goede wrote: > Now a days the LED core can take care of executing brightness_set from > a workqueue if it needs to sleep, make use of this and remove a bunch > of DIY code for this. > > Since this commit removes the workqueue usage for LEDs, the > led_sysfs_blink_set callback may now also sleep, this is fine. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> For the thinkpad-acpi bits: Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> BTW, one sure-fire way to test this is to attach a trigger fired from atomic context. If it doesn't defer to a workqueue, the machine *will* crash. Thinkpad-acpi LEDs need to sleep (and will trigger an SMI, etc, etc). -- Henrique Holschuh
