Hi Andi,
Thanks for the patch.
On 01/04/2017 02:41 PM, Andi Shyti wrote:
> Some devices do not handle the led brightness or simply don't
> care about it. Conceptually said devices want to just switch on
> or off the led. It is useless in this case to have a 255 range
> of brightness, while just having an LED_ON and LED_OFF improves
> the boolean meaning of the led status.
>
> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
> ---
> include/linux/leds.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index 569cb531094c..0258f9c49034 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -27,6 +27,7 @@ struct device;
>
> enum led_brightness {
> LED_OFF = 0,
> + LED_ON,
Now lack of explicit value assignment to LED_ON looks weird
since it is surrounded by other initializer values.
I'd prefer to have "LED_ON = 1," in this line.
> LED_HALF = 127,
> LED_FULL = 255,
> };
>
--
Best regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
