On Thu, 29 Dec 2016, Jacek Anaszewski wrote: > Hi Julia, > > This patch doesn't apply to current for-next branch > of linux-leds.git. The information about where it comes from is below the ---. It's automatically send to me by kbuild, so I don't know anything more than that. I recall from the original message that the code was committed around an hour ago. julia > Best regards, > Jacek Anaszewski > > On 12/29/2016 10:10 PM, Julia Lawall wrote: > > Device node iterators put the previous value of the index variable, so an > > explicit put causes a double put. > > > > Generated by: scripts/coccinelle/iterators/device_node_continue.cocci > > > > Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx> > > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> > > --- > > > > I haven't looked at the context in detail, but given the rule, I assume > > that there is an iterator, such as for_each_child_of_node, and these > > iterators do a put on each iteration, so none is needed in the loop body. > > > > tree: https://github.com/manabian/linux-lpc lpc18xx_43xx_devel > > head: 9ee5f58bbb16c08da223c4b4933457e0eb72268d > > commit: c58957273142be779f62c17fae389ce9c134139f [44/55] leds: pca9532: use > > > > leds-pca9532.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > --- a/drivers/leds/leds-pca9532.c > > +++ b/drivers/leds/leds-pca9532.c > > @@ -473,7 +473,6 @@ pca9532_of_populate_pdata(struct device > > > > res = of_property_read_u32(child, "reg", ®); > > if ((res != 0) || (reg >= maxleds)) { > > - of_node_put(child); > > continue; > > } > > > > @@ -484,8 +483,6 @@ pca9532_of_populate_pdata(struct device > > of_property_read_u32(child, "type", &pdata->leds[reg].type); > > of_property_read_string(child, "linux,default-trigger", > > &pdata->leds[reg].default_trigger); > > - > > - of_node_put(child); > > } > > > > return pdata; > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
