On Wed, Dec 14, 2016 at 10:48:37AM +0900, Milo Kim wrote: > Hi Jacek, > > On 12/13/2016 06:44 PM, Jacek Anaszewski wrote: > > > > Could you please verify if leds-lp55xx-common.c driver > > really needs a custom firmware loading fallback mechanism? > > Thanks for sharing this. The lp55xx-common uses this mechanism to load and > run LED effect manually, so this could be a misuse case. > I think the right solution is providing device attributes. Run LED manually using request_firmware()? What the.. yes this sounds odd. > At this moment, four drivers use lp55xx-common code. > > - lp5521, lp5523: OK if we do not support FW loading fallback mechanism > - lp5562, lp8501: need to create additional sysfs alternatively. Phew! > However, we should be careful because I'm not sure this modification will > generate the regression (breaking the user-space) or not. Right so not breaking old userspace is critical. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
