Re: [PATCH v3 1/1] leds: LED driver for TI LP3952 6-Channel Color LED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/10/2016 02:56 PM, Tony Makkiel wrote:



+
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id lp3952_acpi_match[] = {
+    {LP3952_NAME, 0},
+    {}
+};

Could you please share how did you apply ACPI overlay?

I am using the initrd ACPI method of Octavian's patch.

https://lkml.org/lkml/2016/3/31/333

Thanks. Would it be possible to define entries per each LED
connected to the LED controller, similarly as it is in case
of Device Tree bindings?:

Documentation/devicetree/bindings/leds/common.txt


I am not sure. I did a quick skim through ACPI Spec 5.0.
But couldn't find anything.

Found it!, although not relevant for this driver. Please
see last page of
http://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf

Great. The "Package" entries seem to use names compatible with the
Device Tree properties documented in
Documentation/devicetree/bindings/leds/common.txt.

Probably you could also provide LED name in the "Name" entry and obtain
them in the driver directly from ACPI, similarly as it is accomplished
in case of Device Tree.

led_name array from lp3952_register_led_classdev() could be removed
then.

--
Best regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux