On 12 April 2016 at 15:40, Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote: > On 12 April 2016 at 15:27, Boris Brezillon > <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote: >> Hi Ezequiel, >> >> On Tue, 12 Apr 2016 13:26:35 -0300 >> Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote: >> >>> This commit introduces a MTD trigger for flash (NAND/NOR) device >>> activity. The implementation is copied from IDE disk. >>> >>> This deprecates the "nand-disk" LED trigger, but for backwards >>> compatibility, we still keep the "nand-disk" trigger around. >>> >>> The motivation for deprecating the "nand-disk" LED trigger is that >>> it only works for NAND drivers, whereas the "mtd" LED trigger >>> is more generic (in fact, "nand-disk" currently only works for >>> certain NAND drivers). >>> >>> Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> >>> --- >>> drivers/leds/trigger/Kconfig | 8 +++++++ >>> drivers/leds/trigger/Makefile | 1 + >>> drivers/leds/trigger/ledtrig-mtd.c | 49 ++++++++++++++++++++++++++++++++++++++ >>> drivers/mtd/mtdcore.c | 7 ++++++ >>> drivers/mtd/nand/nand_base.c | 29 +--------------------- >>> include/linux/leds.h | 6 +++++ >> >> I'd suggest splitting this patch in 2, one adding ledtrig-mtd code, and >> another one make use of ledtrig_mtd_activity() and removing >> nand-trigger code. >> > > Sure, that sounds good. > One comment about the above: notice that if we split in two patches as you suggest, we would create a dependency between patches. I don't have any problem doing this, but it sounds like it might make maintainers life harder. -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
