In led_classdev_unregister the LED gets switched off. This is fine when the driver module is removed but causes issues when the physical LED device is removed (e.g. USB LED devices). In case of the thingm driver (hid/hid-thingm.c) it complains with ENODEV because the physical LED device is no longer available. When I switched this driver to use the generic workqueue in the LED core then this error was also propagated to set_brightness_delayed and it complains with "Setting an LED's brightness failed (-19)". Recent commit d1aa577f5e19 [turn off the LED and wait for completion on unregistering LED class device] tackled a first potential issue in led_classdev_unregister but it seems like the case of removal of the physical LED device hasn't been considered yet. At a first glance I see no way for the LED core to tell between the two unregister cases (driver module removal vs. physical LED device removal), but maybe I miss something. If we can't tell between the two cases them I'm not sure what's the best solution: Not touching the brightness is general in led_classdev_unregister, live with the situation as it is or add a special handling for ENODEV. -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
