Re: [PATCH 5/7] leds-bcm6328: switch to __raw_readl() and __raw_writel()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Florian, Alvaro

On 11/30/2015 05:32 AM, Florian Fainelli wrote:
Le 29/11/2015 08:35, Álvaro Fernández Rojas a écrit :
Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx>

This driver has a slight chance of running on a BCM63138 SoC which is
ARM-based and little endian, so I would keep the wrapper around here
just so it is easy for somebody to add support for a different platform
later on.

Thanks for sharing this info.

Alvaro - is the performance gain resulting from this change
specifically important for some of your use cases?

---
  drivers/leds/leds-bcm6328.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c
index cd54264..876f0ce 100644
--- a/drivers/leds/leds-bcm6328.c
+++ b/drivers/leds/leds-bcm6328.c
@@ -76,12 +76,12 @@ struct bcm6328_led {

  static void bcm6328_led_write(void __iomem *reg, unsigned long data)
  {
-	iowrite32be(data, reg);
+	__raw_writel(data, reg);
  }

  static unsigned long bcm6328_led_read(void __iomem *reg)
  {
-	return ioread32be(reg);
+	return __raw_readl(reg);
  }

  /**





--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux