Re: [PATCH v2 01/12] leds: core: Use EXPORT_SYMBOL_GPL consistently

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch isn't going to be applied since it can cause
legal implications for existing users.

On 09/28/2015 03:07 PM, Jacek Anaszewski wrote:
LED core has a mixture of EXPORT_SYMBOL and EXPORT_SYMBOL_GPL macros.
This patch fixes this discrepancy and switches to using EXPORT_SYMBOL_GPL
for each exported function.

Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>
---
  drivers/leds/led-core.c |    8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
index 549de7e..c1dd545 100644
--- a/drivers/leds/led-core.c
+++ b/drivers/leds/led-core.c
@@ -83,7 +83,7 @@ void led_blink_set(struct led_classdev *led_cdev,

  	led_blink_setup(led_cdev, delay_on, delay_off);
  }
-EXPORT_SYMBOL(led_blink_set);
+EXPORT_SYMBOL_GPL(led_blink_set);

  void led_blink_set_oneshot(struct led_classdev *led_cdev,
  			   unsigned long *delay_on,
@@ -104,7 +104,7 @@ void led_blink_set_oneshot(struct led_classdev *led_cdev,

  	led_blink_setup(led_cdev, delay_on, delay_off);
  }
-EXPORT_SYMBOL(led_blink_set_oneshot);
+EXPORT_SYMBOL_GPL(led_blink_set_oneshot);

  void led_stop_software_blink(struct led_classdev *led_cdev)
  {
@@ -139,7 +139,7 @@ void led_set_brightness(struct led_classdev *led_cdev,
  		dev_dbg(led_cdev->dev, "Setting LED brightness failed (%d)\n",
  			ret);
  }
-EXPORT_SYMBOL(led_set_brightness);
+EXPORT_SYMBOL_GPL(led_set_brightness);

  int led_update_brightness(struct led_classdev *led_cdev)
  {
@@ -155,7 +155,7 @@ int led_update_brightness(struct led_classdev *led_cdev)

  	return ret;
  }
-EXPORT_SYMBOL(led_update_brightness);
+EXPORT_SYMBOL_GPL(led_update_brightness);

  /* Caller must ensure led_cdev->led_access held */
  void led_sysfs_disable(struct led_classdev *led_cdev)



--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux