Petr Cvek <petr.cvek@xxxxxx> writes:
> This patch fixes the charging detection functions for pda_power driver
> (according to newly discovered EGPIOs) and add NiCd backup accumulator
> charging support.
>
> Signed-off-by: Petr Cvek <petr.cvek@xxxxxx>
> ---
> +static int magician_is_usb_online(void)
> +{
> + return gpio_get_value(EGPIO_MAGICIAN_CABLE_INSERTED) &&
> + (!gpio_get_value(EGPIO_MAGICIAN_CABLE_TYPE)); /* USB=0 */
No need to the extra parenthesis, just :
> + return gpio_get_value(EGPIO_MAGICIAN_CABLE_INSERTED) &&
> + !gpio_get_value(EGPIO_MAGICIAN_CABLE_TYPE); /* USB=0 */
As the remaining looks sgood to me, I'll wait for a week for Philipp's ack and
queuing it after with this parenthesis thing fixed, won't cost me much.
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
