Dne 20.8.2015 v 21:32 Robert Jarzmik napsal(a): > Petr Cvek <petr.cvek@xxxxxx> writes: > >> Add support for MAX1586 Vcore regulator. >> >> Signed-off-by: Petr Cvek <petr.cvek@xxxxxx> > I'll leave that for a week and if no objections queue it. > > I would have expected a better commit message : for example, from your patch I > deduce magician has a 1587 regulator, not a 1586 one : that deserves a small > mention in the commit message. Moreover, the Maxim has 2 outputs : one is > connected to VCC_Core of the SoC, what about the other output ? Is it unknown, > or do you know but don't use it ? > You mean V6 - Usim? MAX1587 does not have this pin implemented. I will note it in commit message. > Cheers. > > -- > Robert > -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html