On Thu, Aug 20, 2015 at 04:43:35PM +0200, Jacek Anaszewski wrote: > This patch replaces led_set_brightness_async with > led_set_brightness_nosleep in all places where the most vital was setting > brightness in a non sleeping way but not necessarily asynchronously, which > is not needed for non-blocking drivers. O.K, so i've lost the plot. _sync, _asymc, _nosleep, etc. Too many changes without a clearly documented vision of what you are trying to achieve. How about splitting this up into at least two patch sets. 1) Add the brightness_set_blocking op and the minimum of changes needed to the core to make it work, and the driver changes taking out the work queue. 2) A set of patches cleaning up the core and its API. We want a well documented linux/leds.h and drivers/led/leds.h defining the APIs which users and triggers should be using. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html