On Tue, 2015-07-28 at 08:38 +0200, Jacek Anaszewski wrote: > >>> + /* Register the classdev */ > >>> + rc = devm_led_classdev_register(dev, &powernv_led->cdev); > >>> + if (rc) { > >>> + dev_err(dev, "%s: Classdev registration failed for %s\n", > >>> + __func__, powernv_led->cdev.name); > >>> + } > > Braces are not needed here, Putting my old maintainer hat on for a minute ... this is serious nit picking :-) Arguably, the function being multi-line, the braces do make the code more readable. This is a matter of taste which in such as case which isn't a blatant violation of an important rule should be left to the choice of the code implementor/maintainer. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html