On Tue 2015-07-21 17:43:28, Jacek Anaszewski wrote: > > > On 21.07.2015 11:53, Pavel Machek wrote: > > > >> /* Set LED brightness level */ > >>- /* Must not sleep, use a workqueue if needed */ > >>+ /* Must not sleep if the driver sets LED_BRIGHTNESS_FAST flag */ > >> void (*brightness_set)(struct led_classdev *led_cdev, > >> enum led_brightness brightness); > >> /* > > > >Have fun improving static checkers to check for this kind of crazy > >semantics. > > I'd be grateful if you gave an example of the tool that would > complain about it. I'd be grateful if you would go through all the tools and check that this does _not_ break them. Because what you are doing is quite crazy. Start with lockdep. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html