On Tue 2015-06-30 10:01:08, Jacek Anaszewski wrote: > This patch rearranges the core LED subsystem code, so that it > now removes from drivers the responsibility of using work queues > internally in case their brightness_set ops can sleep. > Addition of two flags: LED_BRIGHTNESS_FAST and LED_BLINK_DISABLE > as well as new_brightness_value property to the struct led_classdev > allows for employing existing set_brightness_work to do the job. > The modifications allow also to get rid of brightness_set_sync op, > as flash LED devices can now be handled properly only basing on the > SET_BRIGHTNESS_SYNC flag. Are you sure this is good idea? You'll now use single callback for blocking and non-blocking behaviour. I'm pretty sure stuff like lockdep will have some fun with that. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html