On Wed, Apr 15, 2015 at 2:11 AM, Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> wrote: > Hi Sebastian, > > On 04/14/2015 11:23 PM, Sebastian Hesselbarth wrote: >> >> In gpio_leds_create(), when devm_get_gpiod_from_child() fails with >> -EPROBE_DEFER on the second gpio led to be created, the first already >> registered led is not torn down properly. This causes create_gpio_led() >> to fail for the first led on re-probe(). >> >> Fix this misbehaviour by incrementing num_leds only if all >> potentially failing calls completed successfully. >> >> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> >> --- >> Cc: Bryan Wu <cooloney@xxxxxxxxx> >> Cc: Richard Purdie <rpurdie@xxxxxxxxx> >> Cc: linux-leds@xxxxxxxxxxxxxxx >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> --- >> drivers/leds/leds-gpio.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > > For this patch: > > Acked-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> > Thanks, I merged it. -Bryan > I have a question regarding the sequence above on line 201: > > if (!led.name) > return ERR_PTR(-EINVAL); > > Shouldn't this be also 'goto err"? > > -- > Best Regards, > Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
