Hi Ricardo, On 03/26/2015 03:22 PM, Ricardo Ribalda Delgado wrote:
Hello I thought real programmers count from zero :), Jokes aside, I think it is the convention in the kernel to start from 0 (video0, mmc0....) Also the patch is wrong, it will always show the info message "led renamed to...", becase led_classdev_register expects 0 when the device has not been renamed, with this patch you will return 1. Best Regards Nacked-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
Oops, I didn't notice this :-/ Getting back to numeration - in the LED subsystem devices don't get numerical suffixes, if they are not duplicated. For V4L2 case every device name begins from 'video' so adding the numbers from 0 is reasonable. For LED subsystem having devices e.g. aat1290 and aat1290_1 would be confusing IMO. -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
