On Wed, Dec 3, 2014 at 9:17 PM, Grant Likely <grant.likely@xxxxxxxxxx> wrote:
> On Wed, Dec 3, 2014 at 5:57 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
>> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>>
>> Since commit a43f2cbbb009f96 ("leds: leds-gpio: Make use of device property
>> API") it is no longer possible to register multiple gpio leds without passing
>> the 'label' property.
>>
>> According to Documentation/devicetree/bindings/leds/common.txt:
>>
>> "Optional properties for child nodes:
>> - label : The label for this LED. If omitted, the label is
>> taken from the node name (excluding the unit address)."
>>
>> So retrieve the node name when the 'label' property is absent to keep the old
>> behaviour and fix this regression.
>>
>> Reported-by: Jean-Michel Hautbois <jean-michel.hautbois@xxxxxxxxxxx>
>> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> Acked-by: Grant Likely <grant.likely@xxxxxxxxxx>
>
> (Assuming that creating a fwnode_get_name() function turns out to be a
> non-starter.)
Thanks, Grant.
Maybe we should go with this v2 patch initially to fix the regression
and then we could consider introducing fwnode_get_name() in a future
patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
