During review of "LED / flash API integration" patch sets two issues
requiring modifications in the LED subsystem core emerged.
I would like to consult possible ways of solving them:
1.
==================================================================
Some LED devices allow to control multiple LEDs independently.
Currently there is no direct support for this in the LED subsystem
and existing drivers register separate devices for each LED.
LED / flash API integration effort is a good opportunity to provide
support for exposing multiple LEDs by a single LED class device.
I would like to add following API:
/**
* led_get_sub_leds_number - get the number of exposed LEDs
* @led_cdev: the LED to query
* @num_leds: number of exposed leds
*
* Get the number of leds exposed by the device.
*
* Returns: 0 on success or negative error value on failure
*/
int led_get_sub_leds_number(struct led_classdev *led_cdev,
int *num_leds);
/**
* led_select_sub_led - select sub led to control
* @led_cdev: the LED to set
* @led_id: id of the sub led to control
*
* Set the sub led to be the target of the LED class API calls.
* Maximum led_id equals num_leds - 1.
*
* Returns: 0 on success or negative error value on failure
*/
int led_select_sub_led(struct led_classdev *led_cdev,
int led_id);
/**
* led_get_sub_led - get currently selected sub led
* @led_cdev: the LED to set
* @led_id: id of currently selected sub led
*
* Get id of the sub led chosen as the target of LED class
* API calls. Maximum led_id equals num_leds - 1.
*
* Returns: 0 on success or negative error value on failure
*/
int led_get_target_led(struct led_classdev *led_cdev,
int* led_id);
The functions functions would be mapped on the sysfs attributes:
- available_leds - RO
- sub_led_id - RW
The attributes would be created only if the related callbacks
are registered by the driver.
2.
==================================================================
The second issue, refers to the work queues being used in the
brightness_set callbacks of the LED subsystem drivers. It interferes
with the way how V4L2 Flash controls work, which expect that setting
flash brightness has immediate effect.
Proposed solutions:
- move work queues out from the drivers to the LED core.
- add brightness_set_now callback to be registered by
the LED drivers and intended for call by v4l2-flash driver;
it wouldn't schedule a work but do the job immediately
==================================================================
I'd be glad to hear any comments on this.
Thanks,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
