Re: [PATCH] leds: Turn off led if blinking is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 4, 2014 at 12:11 AM, Stefan Sørensen
<stefan.sorensen@xxxxxxxxxxxxxxx> wrote:
> When using the timer trigger and setting delay_on to 0, the led
> will stay in whatever state is was in, while intuitively one
> would expect it to turn off. This patch changes the behaviour to
> turn it off.
>

Good to me, applied to my tree.
Thanks,
-Bryan

> Signed-off-by: Stefan Sørensen <stefan.sorensen@xxxxxxxxxxxxxxx>
> ---
>  drivers/leds/led-core.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
> index ce8921a..71b40d3 100644
> --- a/drivers/leds/led-core.c
> +++ b/drivers/leds/led-core.c
> @@ -39,9 +39,11 @@ static void led_set_software_blink(struct led_classdev *led_cdev,
>         led_cdev->blink_delay_on = delay_on;
>         led_cdev->blink_delay_off = delay_off;
>
> -       /* never on - don't blink */
> -       if (!delay_on)
> +       /* never on - just set to off */
> +       if (!delay_on) {
> +               __led_set_brightness(led_cdev, LED_OFF);
>                 return;
> +       }
>
>         /* never off - just set to brightness */
>         if (!delay_off) {
> --
> 1.8.5.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux