On Wednesday 08 January 2014 01:32:15 Bryan Wu wrote: > On Tue, Jan 7, 2014 at 12:42 PM, Pavel Machek <pavel@xxxxxx> wrote: > > Hi! > > > > There's some locking weirdness, and few missing comments in > > lp5523 driver. > > > > Now, this is untested patch from my reverse-engineering. I > > hope I understood things right... > > > > In particular, there's unbalanced unlock in > > lp5523_update_program_memory, and > > lp5523_update_program_memory needs to be protected by the > > lock. > > > > Comments? Does someone maintain this? > > Actually the locking issue was fixed in my for-next branch, > http://git.kernel.org/cgit/linux/kernel/git/cooloney/linux-led > s.git/commit/?h=for-next&id=0d70bdb957cde2c25a4b3e4c93d0d33403 > 795be9 > > Thanks, > -Bryan > Now, with linus tree lp5523 driver does not work without above commit on Nokia N900 device. I think that commit should go to 3.13 and stable... What do you think? -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.
