On 3 January 2014 04:12, Bryan Wu <cooloney@xxxxxxxxx> wrote: > On Mon, Dec 30, 2013 at 1:09 AM, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote: >> Fixes following build error. >> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’: >> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of >> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration] >> > > I don't see any building error with s3c2410_defconfig. Actually this > <plat/gpio-cfg.h> is included in > arch/arm/mach-s3c24xx/include/mach/gpio.h which is in > arch/arm/include/asm/gpio.h, then <linux/gpio.h> > This requires that CONFIG_NEED_MACH_GPIO_H is defined. Following commit has removed this option for s3c24xx platform. c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>"). -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html