On Sat, Dec 28, 2013 at 7:00 AM, ZHAO Gang <gamerh2o@xxxxxxxxx> wrote: > Use the more convenient macro. > Good, applied. Thanks, -Bryan > Signed-off-by: ZHAO Gang <gamerh2o@xxxxxxxxx> > --- > drivers/leds/led-triggers.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c > index 3c972b2..e387f41 100644 > --- a/drivers/leds/led-triggers.c > +++ b/drivers/leds/led-triggers.c > @@ -242,18 +242,14 @@ EXPORT_SYMBOL_GPL(led_trigger_unregister); > void led_trigger_event(struct led_trigger *trig, > enum led_brightness brightness) > { > - struct list_head *entry; > + struct led_classdev *led_cdev; > > if (!trig) > return; > > read_lock(&trig->leddev_list_lock); > - list_for_each(entry, &trig->led_cdevs) { > - struct led_classdev *led_cdev; > - > - led_cdev = list_entry(entry, struct led_classdev, trig_list); > + list_for_each_entry(led_cdev, &trig->led_cdevs, trig_list) > led_set_brightness(led_cdev, brightness); > - } > read_unlock(&trig->leddev_list_lock); > } > EXPORT_SYMBOL_GPL(led_trigger_event); > @@ -264,16 +260,13 @@ static void led_trigger_blink_setup(struct led_trigger *trig, > int oneshot, > int invert) > { > - struct list_head *entry; > + struct led_classdev *led_cdev; > > if (!trig) > return; > > read_lock(&trig->leddev_list_lock); > - list_for_each(entry, &trig->led_cdevs) { > - struct led_classdev *led_cdev; > - > - led_cdev = list_entry(entry, struct led_classdev, trig_list); > + list_for_each_entry(led_cdev, &trig->led_cdevs, trig_list) { > if (oneshot) > led_blink_set_oneshot(led_cdev, delay_on, delay_off, > invert); > -- > 1.8.4.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html