Re: [PATCH 4/5] leds: leds-mc13783: Remove unnecessary cleaning of registers on exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 14, 2013 at 3:00 AM, Alexander Shiyan <shc_work@xxxxxxx> wrote:
> LED core switches each LED to OFF-state on exit, so there is no need
> for resetting registers.
>
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
>  drivers/leds/leds-mc13783.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
> index 40e4de0..b5a8357 100644
> --- a/drivers/leds/leds-mc13783.c
> +++ b/drivers/leds/leds-mc13783.c
> @@ -224,7 +224,6 @@ static int __init mc13xxx_led_probe(struct platform_device *pdev)
>  static int mc13xxx_led_remove(struct platform_device *pdev)
>  {
>         struct mc13xxx_leds *leds = platform_get_drvdata(pdev);
> -       struct mc13xxx *mcdev = leds->master;
>         int i;
>
>         for (i = 0; i < leds->num_leds; i++) {
> @@ -232,9 +231,6 @@ static int mc13xxx_led_remove(struct platform_device *pdev)
>                 cancel_work_sync(&leds->led[i].work);
>         }
>
> -       for (i = 0; i < leds->devtype->num_regs; i++)
> -               mc13xxx_reg_write(mcdev, leds->devtype->ledctrl_base + i, 0);
> -

This one looks good to me,
-Bryan


>         return 0;
>  }
>
> --
> 1.8.3.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux