Hello. > On Sat, Dec 14, 2013 at 3:00 AM, Alexander Shiyan <shc_work@xxxxxxx> wrote: > > This patch adds support for two LEDs on MC34708 PMIC. > > > > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx> > > --- ... > > diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c > > index ca87a1b..e61bdb5 100644 > > --- a/drivers/leds/leds-mc13783.c > > +++ b/drivers/leds/leds-mc13783.c ... > > - ret = led_classdev_register(pdev->dev.parent, > > - &leds->led[i].cdev); > > + ret = led_classdev_register(dev, &leds->led[i].cdev); > > Is this correct changing? I think it should be > ret = led_classdev_register(dev->parent, &leds->led[i].cdev); > > Besides this, this patch is good to me. Yes. LEDs parent should be our new platform device i.e. &pdev->dev, not the mc13xxx MFD core device. I think it was a typo initially. Is not it? Thanks. --- ��.n��������+%������w��{.n�����{��W����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f