Re: [PATCH 2/3] leds: lp5521/5523: Remove duplicate mutex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bryan,

On 12/03/2013 04:40 AM, Bryan Wu wrote:
On Wed, Nov 20, 2013 at 10:14 PM, Milo Kim <milo.kim@xxxxxx> wrote:
It can be a problem when a pattern is loaded via the firmware interface.
LP55xx common driver has already locked the mutex in 'lp55xx_firmware_loaded()'.
So it should be deleted.


Looks like lp5521_update_program_memory() will be called by
store_engine_load() without holding a lock after this change, is this
correct? I think you need also update store_engine_load() to hold the
lock when calling lp5521_update_program_memory().

Thanks, good point! I've just sent the patch-v2.

Best regards,
  Milo

--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux